Please fix the table creation code

Tim created the topic: Please fix the table creation code

Hi!

I'm a sysadmin at a university where several departments are using WordPress, and at least one is using your Twitter Integration Plugin.

Your twitter_integration table, that's created in the twitter_integration_activate() function, is forcing the table format to be MyISAM. You're not doing any FULLTEXT indexing, so as far as I can tell, forcing the table type to MyISAM isn't required. Since it's not specifically required by your code, overriding the system default is actually a mistake.

It's a mistake because on a MySQL database server where InnoDB (or some other table type!) is the default, all of the other WordPress tables are likely in the default format, but the wp_twitter_integration table will be forced to be in MyISAM. InnoDB and MyISAM don't share the same tuning settings for things like buffer sizes, so on a modern MySQL (or Percona, or MariaDB) server where the site is defaulting to InnoDB and the administrators haved tuned for InnoDB, forcing a specific table to be the older MyISAM format for no real reason just wastes resources.

In short, if you don't actually require MyISAM, don't force it: just leave the ENGINE=MyISAM out of the table creation code, and allow the table to be created using whatever the default is for the system.

#15383

Please Log in or Create an account to join the conversation.


Support replied the topic: Please fix the table creation code

Dear Tim,

Thank you for your suggestion. We will change it. If you have not changed it yet, we will change it for you too.


Best regards,
Web-Dorado team


Joomla extensions ,
Wordpress plugins ,
Drupal modules
#15401
The following user(s) said Thank You: Tim

Please Log in or Create an account to join the conversation.


Tim replied the topic: Please fix the table creation code

Support wrote: Dear Tim,

Thank you for your suggestion. We will change it. If you have not changed it yet, we will change it for you too.


Thanks for the quick response! We're going to be changing that table type to InnoDB for our databases as we migrate to a new system with MariaDB 5.5.x. We ran into engine conversion issues for some other MyISAM tables (ones that use FULLTEXT indexes) for other databases, but the wp_twitter_integration table converted without any issues during testing.

Thanks again,

Tim

#15428

Please Log in or Create an account to join the conversation.


Time to create page: 0.183 seconds
Powered by Kunena Forum

WORLD-CLASS SUPPORT

We are here for you every step of the way. Turn to our support with any questions you might have about our products and services. Our experienced customer care team is available to help you as fast as we possibly can.

Contact us